From f9e3e8c5f81a8e753da1d3e4b7eab21a02dde921 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Sun, 19 Apr 2026 22:49:21 +0100 Subject: [PATCH] Pin artist_refresh_wikipedia_data assertions Bind perform_job results and assert id equality. For the unchanged case, also assert wikipedia_data is the same as before the job ran. Refs #176 --- .../worker/artist_refresh_wikipedia_data_test.exs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/music_library/worker/artist_refresh_wikipedia_data_test.exs b/test/music_library/worker/artist_refresh_wikipedia_data_test.exs index bf9f9a7d..48f54650 100644 --- a/test/music_library/worker/artist_refresh_wikipedia_data_test.exs +++ b/test/music_library/worker/artist_refresh_wikipedia_data_test.exs @@ -31,7 +31,8 @@ defmodule MusicLibrary.Worker.ArtistRefreshWikipediaDataTest do end end) - assert {:ok, _} = perform_job(ArtistRefreshWikipediaData, %{"id" => artist_info.id}) + assert {:ok, refreshed} = perform_job(ArtistRefreshWikipediaData, %{"id" => artist_info.id}) + assert refreshed.id == artist_info.id updated = Artists.get_artist_info!(artist_info.id) assert is_map(updated.wikipedia_data) @@ -44,7 +45,9 @@ defmodule MusicLibrary.Worker.ArtistRefreshWikipediaDataTest do # No wikidata relation in musicbrainz_data → fetch_wikipedia_data returns {:ok, artist_info} # Worker wraps non-error returns with `with`, so it passes through as :ok - assert {:ok, _} = perform_job(ArtistRefreshWikipediaData, %{"id" => artist_info.id}) + assert {:ok, unchanged} = perform_job(ArtistRefreshWikipediaData, %{"id" => artist_info.id}) + assert unchanged.id == artist_info.id + assert unchanged.wikipedia_data == artist_info.wikipedia_data end end end