From fa77b62473c0f1e4893bab749f3f0bc6c5c23a60 Mon Sep 17 00:00:00 2001 From: Claudio Ortolina Date: Sun, 15 Jun 2025 00:08:51 +0300 Subject: [PATCH] Use dropdown instead of actions_menu in scrobble activity --- .../live/stats_live/index.html.heex | 60 ++++++++++--------- 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/lib/music_library_web/live/stats_live/index.html.heex b/lib/music_library_web/live/stats_live/index.html.heex index 2f031c1e..4016d949 100644 --- a/lib/music_library_web/live/stats_live/index.html.heex +++ b/lib/music_library_web/live/stats_live/index.html.heex @@ -203,7 +203,7 @@ - <.actions_menu + <.dropdown :if={ album.metadata.musicbrainz_id !== "" and !tracked_record?( @@ -211,19 +211,21 @@ album.metadata.musicbrainz_id ) } - id={album.scrobbled_at_uts} - background_container_target="#records > li" + id={"actions-#{album.scrobbled_at_uts}-albums"} + placement="bottom-end" > - <:button> + <:toggle> {gettext("Choose which format to import")} - <.icon name="hero-star" class="-mt-1 h-5 w-5" aria-hidden="true" data-slot="icon" /> - - <:links> - <.link + <.icon + name="hero-star" + class="-mt-1 h-5 w-5 text-zinc-500 dark:text-zinc-400 cursor-pointer" + aria-hidden="true" + data-slot="icon" + /> + + <.focus_wrap id={"actions-#{album.scrobbled_at_uts}-albums-focus-wrap"}> + <.dropdown_link :for={format <- Records.Record.formats()} - class="block px-3 py-1 text-sm leading-6 text-zinc-900 dark:text-zinc-400 hover:bg-zinc-50 dark:hover:text-zinc-300 dark:hover:bg-zinc-700" - role="menuitem" - tabindex="0" id={"actions-#{album.scrobbled_at_uts}-#{format}-import"} phx-click={ JS.push("import", @@ -233,9 +235,9 @@ } > {format_label(format)} - - - + + + @@ -304,7 +306,7 @@ - <.actions_menu + <.dropdown :if={ track.album.musicbrainz_id !== "" and !tracked_record?( @@ -312,19 +314,21 @@ track.album.musicbrainz_id ) } - id={track.scrobbled_at_uts} - background_container_target="#records > li" + id={"actions-#{track.scrobbled_at_uts}-tracks"} + placement="bottom-end" > - <:button> + <:toggle> {gettext("Choose which format to import")} - <.icon name="hero-star" class="-mt-1 h-5 w-5" aria-hidden="true" data-slot="icon" /> - - <:links> - <.link + <.icon + name="hero-star" + class="-mt-1 h-5 w-5 text-zinc-500 dark:text-zinc-400 cursor-pointer" + aria-hidden="true" + data-slot="icon" + /> + + <.focus_wrap id={"actions-#{track.scrobbled_at_uts}-tracks-focus-wrap"}> + <.dropdown_link :for={format <- Records.Record.formats()} - class="block px-3 py-1 text-sm leading-6 text-zinc-900 dark:text-zinc-400 hover:bg-zinc-50 dark:hover:text-zinc-300 dark:hover:bg-zinc-700" - role="menuitem" - tabindex="0" id={"actions-#{track.scrobbled_at_uts}-#{format}-import"} phx-click={ JS.push("import", @@ -334,9 +338,9 @@ } > {format_label(format)} - - - + + +