Commit Graph

294 Commits

Author SHA1 Message Date
Claudio Ortolina f42f050de0 Simplify scrobbled tracks layout
Remove no results view
2025-09-16 21:01:44 +03:00
Claudio Ortolina c549a7cc6b Update scrobbled track form
- Show artwork
- Remove input to change datetime
- Improve styling of actions
2025-09-16 12:56:42 +03:00
Claudio Ortolina dae334b1b7 Scrobbled tracks CRUD
- Failing tests
- Warnings
2025-09-16 12:45:36 +03:00
Claudio Ortolina 7ac517a025 Add notes to artists 2025-09-07 14:35:16 +03:00
Claudio Ortolina 45610a4a9a Edit notes instead of record notes 2025-09-07 12:22:45 +03:00
Claudio Ortolina 422ce9f203 Add switch to read or edit notes 2025-09-05 22:24:04 +03:00
Claudio Ortolina 94f381e3c3 Raw edit notes 2025-09-05 18:00:01 +03:00
Claudio Ortolina 84c86254ac Show message for no records for day 2025-09-03 08:03:31 +03:00
Claudio Ortolina 3316df1861 Shorten counter titles in stats 2025-09-02 12:36:22 +03:00
Claudio Ortolina a4670412df Add total scrobble count to stats 2025-09-02 08:17:42 +03:00
Claudio Ortolina b932ad0ef4 Add some more metadata to records release on this day 2025-09-02 08:07:28 +03:00
Claudio Ortolina ec20afeaac Fix universal search shortcut modifier instructions 2025-08-31 09:41:37 +03:00
Claudio Ortolina a755633877 Better encapsulation for universal search 2025-08-30 22:30:43 +03:00
Claudio Ortolina 7358608eca Rename FormComponent -> RecordFormComponent 2025-08-30 22:16:20 +03:00
Claudio Ortolina 064ece03f3 Show how many years ago for "On this day" records 2025-08-29 13:09:27 +03:00
Claudio Ortolina f47cbc77f5 Add "On this day" section to stats 2025-08-29 12:20:46 +03:00
Claudio Ortolina df4ca83aeb Add ability to rotate dominant colors 2025-08-27 21:11:13 +03:00
Claudio Ortolina 918ab186ec Fix top tabs on mobile 2025-08-24 20:22:57 +03:00
Claudio Ortolina df46759a8d Extract top artists component and lazy load each tab 2025-08-17 23:30:42 +03:00
Claudio Ortolina af7e48507d Extract top albums component 2025-08-17 23:30:42 +03:00
Claudio Ortolina a85c9456ed Add data credits in footer 2025-07-27 12:45:21 +01:00
Claudio Ortolina 91e39124af Simplify online shops UI in wishlist detail view 2025-07-16 11:18:35 +01:00
Claudio Ortolina f89d28fae5 Standardize and simplify online store templates list markup 2025-07-15 10:40:39 +01:00
Claudio Ortolina 6386e5e20d Fix live preview for new templates 2025-07-15 10:20:07 +01:00
Claudio Ortolina f329d66fb1 Add format to online store templates 2025-07-15 10:08:40 +01:00
Claudio Ortolina 65de5fc833 Add first version of online stores for wishlisted records (claude)
See docs/plans/online_stores.md
2025-07-15 09:42:59 +01:00
Claudio Ortolina 3b08006624 Rename "Collected release" -> "Wishlisted release" 2025-07-13 17:53:31 +01:00
Claudio Ortolina 939c36865f Allow editing a record title 2025-07-13 11:05:29 +01:00
Claudio Ortolina fea5e3e862 Use responsive list for scrobble rules list 2025-07-13 10:17:40 +01:00
Claudio Ortolina 24ff180b56 Change button copy from "Apply All Rules" to "Apply All" 2025-07-12 18:05:46 +01:00
Claudio Ortolina 2aeae28cd5 First pass at manual editing of dominant colors 2025-07-11 08:54:34 +01:00
Claudio Ortolina 9ecbd470af Add button to copy selected release ID 2025-07-07 13:48:00 +01:00
Claudio Ortolina ad74560cf9 Enable Ctrl/Meta+K to trigger universal search 2025-07-07 11:36:41 +01:00
Claudio Ortolina f57485e509 Allow manual upload of artist image 2025-07-06 16:57:30 +01:00
Claudio Ortolina 4b27699d47 Remove copy about unsupported keyboard shortcuts 2025-07-06 10:19:31 +01:00
Claudio Ortolina 3787736e39 Remove custom loading state logic 2025-07-06 09:44:42 +01:00
Claudio Ortolina f5092e32c5 Use Fluxon elements for universal search 2025-07-05 19:28:57 +01:00
Claudio Ortolina 543cbe39b7 Misc universal search improvements
- Use zinc instead of gray
- Translate all strings, and remove redundant ones
- Add format, type and release year to record results
- Use existing helpers instead of hand-rolled variants
2025-07-05 19:14:42 +01:00
Claudio Ortolina 1688fa3663 Improve main action button group in scrobble rules page 2025-07-04 15:45:21 +01:00
Claudio Ortolina 29ea381167 Render scrobble rule status with badge 2025-07-04 14:55:46 +01:00
Claudio Ortolina 40346d9123 Render scrobble rule type with badge 2025-07-04 14:53:27 +01:00
Claudio Ortolina 81f0ec8830 Render scrobble rules list with Fluxon table 2025-07-04 14:07:35 +01:00
Claudio Ortolina bb6c838d6a Remove unnecessary explanation text 2025-07-04 13:36:29 +01:00
Claudio Ortolina 93e10bc5d9 Remove excessively defensive coding 2025-07-03 21:18:21 +01:00
Claudio Ortolina d91685b646 First rough implementation of scrobble rules (Claude)
This plan outlines the implementation of functionality to manage
arbitrary rules for fixing data in the `scrobbled_tracks` table. The
system will support two types of transformations:

1. **Album Rule**: Update the album MusicBrainz ID of all tracks
belonging to a specific album (identified by album title)
2. **Artist Rule**: Update the artist MusicBrainz ID of all tracks
belonging to a specific artist (identified by artist name)

- `scrobbled_tracks` table exists with the following structure:
  - `scrobbled_at_uts` (integer, primary key)
  - `musicbrainz_id` (string) - track MusicBrainz ID
  - `title` (string) - track title
  - `cover_url` (string)
  - `scrobbled_at_label` (string)
  - `artist` (map) - embedded artist data with `musicbrainz_id` and
`name`
  - `album` (map) - embedded album data with `musicbrainz_id` and
`title`
  - `last_fm_data` (map) - raw Last.fm API response

- `LastFm.Track` - Schema for scrobbled tracks
- `LastFm.Artist` - Embedded artist schema
- `LastFm.Album` - Embedded album schema

- Main navigation has Stats, Collection, Wishlist sections
- "More" dropdown contains development tools and utilities
- Uses Phoenix LiveView for interactive components

**File**:
`priv/repo/migrations/YYYYMMDDHHMMSS_create_scrobble_rules.exs`

Create `scrobble_rules` table with:

- `id` (primary key)
- `type` (string) - "album" or "artist"
- `match_value` (string) - album title or artist name to match
- `target_musicbrainz_id` (string) - MusicBrainz ID to set
- `enabled` (boolean) - whether rule is active
- `description` (text) - optional description for the rule
- `inserted_at` (timestamp)
- `updated_at` (timestamp)

Indexes:

- `type, match_value` (compound index for efficient matching)
- `enabled` (for filtering active rules)

**File**: `lib/music_library/scrobble_rules/scrobble_rule.ex`

Create Ecto schema with:

- Field definitions matching migration
- Validations:
  - `type` must be "album" or "artist"
  - `match_value` required and non-empty
  - `target_musicbrainz_id` required and non-empty
  - `enabled` defaults to true
- Changeset functions for create/update operations

**File**: `lib/music_library/scrobble_rules.ex`

Implement context functions:

- `list_scrobble_rules(opts \\ [])` - list all rules with optional
filtering
- `get_scrobble_rule!(id)` - get specific rule by ID
- `create_scrobble_rule(attrs)` - create new rule
- `update_scrobble_rule(rule, attrs)` - update existing rule
- `delete_scrobble_rule(rule)` - delete rule
- `change_scrobble_rule(rule, attrs \\ %{})` - create changeset
- `list_enabled_rules()` - get only enabled rules for worker
- `apply_album_rule(rule)` - apply album transformation
- `apply_artist_rule(rule)` - apply artist transformation
- `apply_all_rules()` - apply all enabled rules

**File**: `lib/music_library_web/components/layouts/app.html.heex`

Add new navigation link in the "More" dropdown:

- Icon: `hero-adjustments-horizontal`
- Label: "Scrobble Rules"
- Route: `/scrobble-rules`
- Position: After "Oban" link, before separator

**File**: `lib/music_library_web/router.ex`

Add new LiveView routes in the authenticated scope:

- `/scrobble-rules` - index page
- `/scrobble-rules/new` - create new rule
- `/scrobble-rules/:id/edit` - edit existing rule

**File**: `lib/music_library_web/live/scrobble_rules_live/index.ex`

Implement LiveView with:

- List view showing all rules with status indicators
- Create/Edit forms with validation
- Delete confirmation
- Filter controls (by type, enabled/disabled)
- Manual rule application triggers
- Real-time updates via PubSub

**Template**:
`lib/music_library_web/live/scrobble_rules_live/index.html.heex`

- Table layout with rule details
- Action buttons (Edit, Delete, Apply)
- Form components for create/edit
- Status indicators for enabled/disabled rules

**File**:
`lib/music_library_web/live/scrobble_rules_live/form_component.ex`

Create reusable form component:

- Type selection (album/artist)
- Match value input with validation
- Target MusicBrainz ID input
- Description textarea
- Enable/disable toggle
- Save/Cancel actions

Where possible, use the components available at
<https://docs.fluxonui.com/1.1.4/overview.html>.

**File**: `lib/music_library/scrobble_rules/worker.ex`

Implement Oban worker:

- Scheduled to run periodically (e.g., every 30 minutes)
- Fetches all enabled rules
- Applies each rule in sequence
- Logs application results
- Handles errors gracefully
- Tracks last application time

**File**: `test/music_library/scrobble_rules_test.exs`

- Test all context functions
- Test rule application logic
- Test edge cases and error handling

**File**: `test/music_library/scrobble_rules/scrobble_rule_test.exs`

- Test schema validations
- Test changeset functions
- Test constraint validations

**File**: `test/music_library_web/live/scrobble_rules_live_test.exs`

- Test LiveView interactions
- Test form submissions
- Test real-time updates
- Test navigation and routing

**File**: `test/music_library/scrobble_rules/worker_test.exs`

- Test job execution
- Test rule application
- Test error handling
- Test scheduling

- Ensure atomic operations when applying rules
- Validate MusicBrainz IDs before applying
- Log all transformations for audit trail

- Index optimization for rule matching
- Batch processing for large datasets
- Rate limiting for external API calls

- Clear feedback on rule application
- Preview mode to show what would change
- Bulk operations for managing multiple rules
- Export/import functionality for rule sets

- Input validation and sanitization
- Rate limiting on rule creation
- Audit logging for all changes

```sql
-- scrobble_rules table
CREATE TABLE scrobble_rules (
  id INTEGER PRIMARY KEY AUTOINCREMENT,
  type TEXT NOT NULL CHECK (type IN ('album', 'artist')),
  match_value TEXT NOT NULL,
  target_musicbrainz_id TEXT NOT NULL,
  enabled BOOLEAN NOT NULL DEFAULT TRUE,
  description TEXT,
  inserted_at TIMESTAMP NOT NULL,
  updated_at TIMESTAMP NOT NULL
);

CREATE INDEX idx_scrobble_rules_type_match ON scrobble_rules(type,
match_value);
CREATE INDEX idx_scrobble_rules_enabled ON scrobble_rules(enabled);
```

```
lib/music_library/
├── scrobble_rules/
│   ├── scrobble_rule.ex          # Schema
│   └── worker.ex                 # Oban worker
└── scrobble_rules.ex             # Context

lib/music_library_web/
└── live/
    └── scrobble_rules_live/
        ├── index.ex              # LiveView
        ├── index.html.heex       # Template
        └── form_component.ex     # Form component

priv/repo/migrations/
└── YYYYMMDDHHMMSS_create_scrobble_rules.exs

test/
├── music_library/
│   ├── scrobble_rules_test.exs
│   └── scrobble_rules/
│       ├── scrobble_rule_test.exs
│       └── worker_test.exs
└── music_library_web/
    └── live/
        └── scrobble_rules_live_test.exs
```

1. Database migration and schema
2. Context module with basic CRUD operations
3. LiveView interface for rule management
4. Navigation and routing updates
5. Periodic worker implementation
6. Comprehensive testing
7. Documentation and deployment

This plan ensures a robust, maintainable solution that integrates
seamlessly with the existing Music Library application architecture.
2025-07-03 16:47:08 +01:00
Claudio Ortolina 82e9d3c5a7 Extract markup from stats live to separate set of components 2025-06-29 08:49:12 +01:00
Claudio Ortolina e2c2c6d547 Add tooltips for scrobble activity debug info 2025-06-21 15:20:24 +03:00
Claudio Ortolina f3425d8cb9 Add top artist and top albums of all time
Executed by Claude
2025-06-19 17:17:51 +03:00
Claudio Ortolina 9b20db762d Show top artists in stats page 2025-06-16 16:47:35 +03:00
Claudio Ortolina 389c268344 Add another feed refresh button 2025-06-15 11:51:45 +03:00