53348a328e
Relax ScrobbleRule.t to allow unpersisted structs
2026-04-21 12:47:38 +01:00
87d2a8f186
Fix Maintenance vacuum/optimize return specs
2026-04-21 12:47:18 +01:00
40ac5bdc99
Widen Transform.new/1 spec to accept keyword list
2026-04-21 12:47:00 +01:00
29bfa20978
Remove unreachable error clauses in form save helpers
2026-04-21 12:46:35 +01:00
a93ef6d076
Install and configure dialyzer
2026-04-21 12:27:27 +01:00
ed4e92b1a7
Cover Ignore a few other modules
2026-04-20 23:00:44 +01:00
56983c3e2c
Update tailwind from 4.2.2 to 4.2.3
2026-04-20 22:47:38 +01:00
dc71b2ff90
Fix badge align issue in barcode scan cart
2026-04-20 16:04:20 +01:00
8d004d39cc
Extract shared cart sidebar component
2026-04-20 15:57:44 +01:00
9851a5c6bf
Use cart with barcode scanner
2026-04-20 15:46:40 +01:00
d47df899b7
Improve layout of add record form
...
Remove results count (I never looked at it)
2026-04-20 15:31:14 +01:00
fd93aaed30
Update architecture docs
2026-04-20 15:15:29 +01:00
7ad094d537
Complete ML-143
2026-04-20 15:15:29 +01:00
eaece07193
Count formats in results
2026-04-20 15:15:29 +01:00
c4ebe636ff
Fix ML-143 review: security, worker, and test improvements
...
Closes ML-143 review findings:
- cast_id/1 uses Integer.parse instead of String.to_integer
- add_to_cart validates against server-side release_groups
- JS.push payload trimmed to {id, format} only
- Oban.insert_all result checked for partial failures
- handle_async success resets @importing? to false
- ImportFromMusicbrainzReleaseGroup gets unique constraint
- Record.parse_datetime/1 made public with safe match
- Workers delegate to Record.parse_datetime/1
- Test coverage: change_format, clear_cart, wishlist single import
2026-04-20 15:15:29 +01:00
3f5ce060b1
Implement ML-143: Cart-style multi record import
...
Closes ML-143.
2026-04-20 15:15:29 +01:00
0ae8e69fb9
Add ML-143: Cart-style multi record import
2026-04-20 11:02:51 +01:00
5c32016c39
Add ML-142: Improve scrobble UI in the Release component
2026-04-20 11:02:25 +01:00
f3d103cf7f
Add backlog section to summary task
2026-04-20 10:11:34 +01:00
cbf29a22bc
Allow backlog mcp commands
2026-04-20 10:07:35 +01:00
f995e01ca7
Import issue history in backlog.md
2026-04-20 10:02:25 +01:00
78487b0085
Pin Wikipedia intro_html to fixture value
...
Map.has_key? verified the key existed but not the content. The
fixture is deterministic — assert the stored value equals
Wikipedia.Fixtures.article_extract_html/0.
Refs #176
2026-04-20 06:50:04 +01:00
a6319d55df
Pin artist_live/show image_data_hash assertions
...
Refs #176
2026-04-20 06:50:04 +01:00
07c99992a3
Pin barcode_scan release assertions
...
Refs #176
2026-04-20 06:50:04 +01:00
162c10e70a
Pin fetch_artist_image asset lookup
...
Refs #176
2026-04-20 06:50:04 +01:00
bce8560ce8
Pin fetch_artist_info stored-data assertions
...
Refs #176
2026-04-20 06:50:04 +01:00
1f457f0f11
Pin prune_assets test to %Asset{hash: ^hash} match
...
Refs #176
2026-04-20 06:50:04 +01:00
8a6c688a56
Assert parsed audit JSON structure
...
Refs #176
2026-04-20 06:50:04 +01:00
0eabe4b3ab
Assert import count > 0 in options-forwarding test
...
Refs #176
2026-04-20 06:50:04 +01:00
8ce5da65e2
Pin Brave search error body assertion
...
Refs #176
2026-04-20 06:50:04 +01:00
cedb86af5d
Pin OpenAI API error assertions to their shapes
...
Refs #176
2026-04-20 06:50:04 +01:00
6adfbea336
Pin Records.populate_genres error to OpenAI prefix
...
Refs #176
2026-04-20 06:50:04 +01:00
0ee0dcb118
Match decoded OpenAI error body, not raw JSON
...
Switch the 500-response stubs to Req.Test.json so Req decodes the
body, then match the map shape. Avoids coupling the assertion to
the exact JSON serialization.
Refs #176
2026-04-20 06:50:04 +01:00
1429f7a826
Drop tautological delete.id checks
...
Repo.delete always returns the struct it was given, so deleted.id
== original.id is trivially true. Thread deleted.id through the
trailing get_*! call instead, so the binding is load-bearing.
Refs #176
2026-04-20 06:50:04 +01:00
bb260437a1
Pin populate_genres error to OpenAI prefix
...
Match the string prefix "OpenAI API error:" that propagates from
OpenAI.gpt on non-2xx responses.
Refs #176
2026-04-20 06:50:04 +01:00
a841ccf8e8
Tighten generate_record_embedding assertions
...
Assert stored embedding text matches the representation helper.
Pin the OpenAI-500 error path to the raw JSON body string.
Refs #176
2026-04-20 06:50:04 +01:00
bbe0d5cd9e
Pin artist_refresh_discogs_data assertions
...
Bind the returned ArtistInfo. For the no-discogs branch, assert
discogs_data was not touched.
Refs #176
2026-04-20 06:50:04 +01:00
f9e3e8c5f8
Pin artist_refresh_wikipedia_data assertions
...
Bind perform_job results and assert id equality. For the unchanged case,
also assert wikipedia_data is the same as before the job ran.
Refs #176
2026-04-20 06:50:04 +01:00
914fb4fbee
Match specific errors on scrobble_rules duplicate
...
Pin the duplicate-rule error to the match_value field and "has already been
taken" message, matching the unique_constraint error_key in the changeset.
Refs #176
2026-04-20 06:50:04 +01:00
9e29de55aa
Pin online_store_templates delete assertion
...
Assert deleted.id == template.id rather than wildcard-matching the
returned struct.
Refs #176
2026-04-20 06:50:04 +01:00
a90fdcf82f
Tighten chats assertions
...
Pin invalid-attrs error to specific field, assert collection UUID round-trips
through Ecto.UUID.cast unchanged, and assert deleted.id == chat.id on delete.
Refs #176
2026-04-20 06:50:04 +01:00
66c36f4d09
Tighten record_sets delete and duplicate assertions
...
Assert deleted.id == set.id on delete, and pin the duplicate error to the
specific field and message from the unique_constraint on record_set_id.
Refs #176
2026-04-20 06:50:04 +01:00
60e95804ad
Tighten similarity test assertions
...
Bind returned embeddings and assert record_id / text_representation match.
Pin OpenAI error path to the actual raw string body returned by the stub.
Refs #176
2026-04-20 06:50:04 +01:00
e0fe5051ec
Pin asset dedup assertion to same-hash
...
The duplicate prevention test asserted `{:ok, _}` twice without checking
that both calls returned the same asset. Assert hash equality.
Refs #176
2026-04-20 06:50:04 +01:00
ae036e79fb
Tighten scrobble_activity assertions
...
Replace 9 `{:ok, _}` sites with specific response-body checks to verify
the context returns the Last.fm API payload and not just the success branch.
Refs #176
2026-04-20 06:50:04 +01:00
cf872cfed0
Secondary sort for artist albums in collection (purchase date desc)
2026-04-19 21:36:07 +01:00
7767933742
Give more space above the universal search input
2026-04-19 21:29:40 +01:00
f6becd85b4
More cover exclusions
2026-04-19 16:50:28 +01:00
beaf38fcfe
Add record_release tests
2026-04-19 16:11:32 +01:00
b79d8ded84
Exclude release module from cover
2026-04-19 16:02:18 +01:00
Claudio Ortolina