music_library/backlog/completed/ml-38 - Inconsistent-Logger-style-in-workers-eager-vs-lazy.md

id, title, status, assignee, created_date, labels, dependencies, references, priority

id	title	status	assignee	created_date	labels	dependencies	references	priority
ML-38	Inconsistent Logger style in workers (eager vs lazy)	Done		2026-04-20 08:53			https://github.com/cloud8421/music_library/issues/139	low

Description

GitHub: created 2026-03-25 · updated 2026-03-25 · closed 2026-03-25

Description

Workers use two different Logger styles:

Lazy (preferred) — PruneAssetCache (lib/music_library/worker/prune_asset_cache.ex:12):

Logger.info(fn -> "Pruned #{prune_count} old cached assets..." end)

Eager — PruneAssets (lib/music_library/worker/prune_assets.ex:34):

Logger.info("Pruned #{count} unreferenced assets.")

Expected behavior

Standardize on lazy logging with fn -> ... end for efficiency (avoids string interpolation when log level is filtered out).

Found during

Codebase consistency audit (2026-03-25)