Files
music_library/backlog/completed/ml-45 - Inconsistent-fetch_-vs-refresh_-naming-in-Artists-context.md
2026-05-04 21:22:27 +01:00

1.1 KiB

id, title, status, assignee, created_date, labels, dependencies, references, priority
id title status assignee created_date labels dependencies references priority
ML-45 Inconsistent fetch_* vs refresh_* naming in Artists context Done
2026-04-20 08:53
https://github.com/cloud8421/music_library/issues/132
medium

Description

GitHub: created 2026-03-25 · updated 2026-03-25 · closed 2026-03-25

Description

The Artists context mixes fetch_* and refresh_* prefixes for the same semantic operation (retrieve external data and upsert locally), with no clear distinction:

  • fetch_artist_info/1 (line 139)
  • refresh_musicbrainz_data/1 (line 159)
  • refresh_discogs_data/1 (line 174)
  • fetch_wikipedia_data/1 (line 199)
  • refresh_wikipedia_data/1 (line 218) — literally an alias for fetch_wikipedia_data/1
  • fetch_image/1 (line 249)
  • fetch_lastfm_data/1 (line 264)

Expected behavior

Standardize on one naming convention. Since Records context uses only refresh_*, aligning Artists to refresh_* would be the consistent choice.

Found during

Codebase consistency audit (2026-03-25)