450 lines
14 KiB
Elixir
450 lines
14 KiB
Elixir
defmodule MusicLibrary.ScrobbleActivityTest do
|
|
use MusicLibrary.DataCase
|
|
|
|
import MusicLibrary.ScrobbledTracksFixtures
|
|
|
|
alias LastFm.Track
|
|
alias MusicLibrary.ScrobbleActivity
|
|
|
|
describe "list_tracks/1" do
|
|
test "returns all tracks when no parameters provided" do
|
|
_track1 = track_fixture(%{title: "First Track"})
|
|
_track2 = track_fixture(%{title: "Second Track"})
|
|
|
|
tracks = list_tracks()
|
|
|
|
assert length(tracks) == 2
|
|
track_titles = Enum.map(tracks, & &1.title)
|
|
assert "First Track" in track_titles
|
|
assert "Second Track" in track_titles
|
|
end
|
|
|
|
test "returns tracks ordered by scrobbled_at_uts by default" do
|
|
_older_track =
|
|
track_fixture(%{
|
|
title: "Older Track",
|
|
scrobbled_at_uts: System.system_time(:second) - 3600
|
|
})
|
|
|
|
_newer_track =
|
|
track_fixture(%{
|
|
title: "Newer Track",
|
|
scrobbled_at_uts: System.system_time(:second)
|
|
})
|
|
|
|
tracks = list_tracks(%{order: :scrobbled_at})
|
|
|
|
assert length(tracks) == 2
|
|
# Should be ordered by scrobbled_at_uts descending (newest first)
|
|
assert List.first(tracks).title == "Newer Track"
|
|
assert List.last(tracks).title == "Older Track"
|
|
end
|
|
|
|
test "returns tracks ordered by title" do
|
|
track_fixture(%{title: "Zebra Track"})
|
|
track_fixture(%{title: "Alpha Track"})
|
|
|
|
tracks = list_tracks(%{order: :title})
|
|
|
|
assert length(tracks) == 2
|
|
assert List.first(tracks).title == "Alpha Track"
|
|
assert List.last(tracks).title == "Zebra Track"
|
|
end
|
|
|
|
test "returns tracks ordered by artist name" do
|
|
track_fixture(%{artist_name: "Zebra Artist", title: "Track 1"})
|
|
track_fixture(%{artist_name: "Alpha Artist", title: "Track 2"})
|
|
|
|
tracks = list_tracks(%{order: :artist})
|
|
|
|
assert length(tracks) == 2
|
|
assert List.first(tracks).artist.name == "Alpha Artist"
|
|
assert List.last(tracks).artist.name == "Zebra Artist"
|
|
end
|
|
|
|
test "returns tracks ordered by album title" do
|
|
track_fixture(%{album_title: "Zebra Album", title: "Track 1"})
|
|
track_fixture(%{album_title: "Alpha Album", title: "Track 2"})
|
|
|
|
tracks = list_tracks(%{order: :album})
|
|
|
|
assert length(tracks) == 2
|
|
assert List.first(tracks).album.title == "Alpha Album"
|
|
assert List.last(tracks).album.title == "Zebra Album"
|
|
end
|
|
|
|
test "filters tracks by search query matching track title" do
|
|
track_fixture(%{title: "Special Track"})
|
|
track_fixture(%{title: "Regular Track"})
|
|
|
|
tracks = list_tracks(%{query: "Special"})
|
|
|
|
assert length(tracks) == 1
|
|
assert List.first(tracks).title == "Special Track"
|
|
end
|
|
|
|
test "filters tracks by search query matching artist name" do
|
|
track_fixture(%{artist_name: "Special Artist", title: "Track 1"})
|
|
track_fixture(%{artist_name: "Regular Artist", title: "Track 2"})
|
|
|
|
tracks = list_tracks(%{query: "Special Artist"})
|
|
|
|
assert length(tracks) == 1
|
|
assert List.first(tracks).artist.name == "Special Artist"
|
|
end
|
|
|
|
test "filters tracks by search query matching album title" do
|
|
track_fixture(%{album_title: "Special Album", title: "Track 1"})
|
|
track_fixture(%{album_title: "Regular Album", title: "Track 2"})
|
|
|
|
tracks = list_tracks(%{query: "Special Album"})
|
|
|
|
assert length(tracks) == 1
|
|
assert List.first(tracks).album.title == "Special Album"
|
|
end
|
|
|
|
test "applies pagination correctly" do
|
|
create_test_tracks(5)
|
|
|
|
# Get first 2 tracks
|
|
tracks_page_1 = list_tracks(%{page: 1, page_size: 2})
|
|
assert length(tracks_page_1) == 2
|
|
|
|
# Get next 2 tracks
|
|
tracks_page_2 = list_tracks(%{page: 2, page_size: 2})
|
|
assert length(tracks_page_2) == 2
|
|
|
|
# Ensure they're different tracks
|
|
page_1_ids = Enum.map(tracks_page_1, & &1.scrobbled_at_uts)
|
|
page_2_ids = Enum.map(tracks_page_2, & &1.scrobbled_at_uts)
|
|
assert Enum.empty?(page_1_ids -- (page_1_ids -- page_2_ids))
|
|
end
|
|
|
|
test "returns empty list when query matches no tracks" do
|
|
track_fixture(%{title: "Test Track"})
|
|
|
|
tracks = list_tracks(%{query: "NonexistentTrack"})
|
|
|
|
assert tracks == []
|
|
end
|
|
end
|
|
|
|
describe "get_track!/1" do
|
|
test "returns the track with given scrobbled_at_uts as integer" do
|
|
track = track_fixture()
|
|
|
|
found_track = ScrobbleActivity.get_track!(track.scrobbled_at_uts)
|
|
|
|
assert found_track.scrobbled_at_uts == track.scrobbled_at_uts
|
|
assert found_track.title == track.title
|
|
end
|
|
|
|
test "returns the track with given scrobbled_at_uts as string" do
|
|
track = track_fixture()
|
|
|
|
found_track = ScrobbleActivity.get_track!(to_string(track.scrobbled_at_uts))
|
|
|
|
assert found_track.scrobbled_at_uts == track.scrobbled_at_uts
|
|
end
|
|
|
|
test "raises Ecto.NoResultsError when track does not exist" do
|
|
assert_raise Ecto.NoResultsError, fn ->
|
|
ScrobbleActivity.get_track!(999_999_999)
|
|
end
|
|
end
|
|
|
|
test "raises Ecto.NoResultsError when given invalid string" do
|
|
assert_raise Ecto.NoResultsError, fn ->
|
|
ScrobbleActivity.get_track!("invalid")
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "update_track/2" do
|
|
test "updates the track with valid attributes" do
|
|
track = track_fixture(%{title: "Original Title"})
|
|
|
|
update_attrs = %{
|
|
title: "Updated Title",
|
|
artist: %{name: "Updated Artist"},
|
|
album: %{title: "Updated Album"}
|
|
}
|
|
|
|
assert {:ok, updated_track} = ScrobbleActivity.update_track(track, update_attrs)
|
|
assert updated_track.title == "Updated Title"
|
|
assert updated_track.artist.name == "Updated Artist"
|
|
assert updated_track.album.title == "Updated Album"
|
|
end
|
|
|
|
test "returns error changeset with invalid attributes" do
|
|
track = track_fixture()
|
|
|
|
invalid_attrs = %{title: ""}
|
|
|
|
assert {:error, %Ecto.Changeset{}} = ScrobbleActivity.update_track(track, invalid_attrs)
|
|
end
|
|
|
|
test "updates scrobbled_at_label" do
|
|
track = track_fixture(%{scrobbled_at_label: "01/01/2024 12:00:00"})
|
|
|
|
update_attrs = %{scrobbled_at_label: "02/02/2024 14:30:00"}
|
|
|
|
assert {:ok, updated_track} = ScrobbleActivity.update_track(track, update_attrs)
|
|
assert updated_track.scrobbled_at_label == "02/02/2024 14:30:00"
|
|
end
|
|
|
|
test "updates cover_url" do
|
|
track = track_fixture(%{cover_url: "https://example.com/old.jpg"})
|
|
|
|
update_attrs = %{cover_url: "https://example.com/new.jpg"}
|
|
|
|
assert {:ok, updated_track} = ScrobbleActivity.update_track(track, update_attrs)
|
|
assert updated_track.cover_url == "https://example.com/new.jpg"
|
|
end
|
|
end
|
|
|
|
describe "delete_track/1" do
|
|
test "deletes the track" do
|
|
track = track_fixture()
|
|
|
|
assert {:ok, %Track{}} = ScrobbleActivity.delete_track(track)
|
|
|
|
assert_raise Ecto.NoResultsError, fn ->
|
|
ScrobbleActivity.get_track!(track.scrobbled_at_uts)
|
|
end
|
|
end
|
|
|
|
test "returns error when track has already been deleted" do
|
|
track = track_fixture()
|
|
{:ok, _} = ScrobbleActivity.delete_track(track)
|
|
|
|
# Attempt to delete again should fail
|
|
assert_raise Ecto.StaleEntryError, fn ->
|
|
ScrobbleActivity.delete_track(track)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "search_tracks_count/1" do
|
|
test "returns total count when no query provided" do
|
|
create_test_tracks(3)
|
|
|
|
count = ScrobbleActivity.search_tracks_count()
|
|
|
|
assert count == 3
|
|
end
|
|
|
|
test "returns filtered count when query provided" do
|
|
track_fixture(%{title: "Special Track"})
|
|
track_fixture(%{title: "Regular Track"})
|
|
track_fixture(%{title: "Another Track"})
|
|
|
|
count = ScrobbleActivity.search_tracks_count("Special")
|
|
|
|
assert count == 1
|
|
end
|
|
|
|
test "returns zero when query matches no tracks" do
|
|
track_fixture(%{title: "Test Track"})
|
|
|
|
count = ScrobbleActivity.search_tracks_count("Nonexistent")
|
|
|
|
assert count == 0
|
|
end
|
|
|
|
test "counts tracks matching artist name" do
|
|
track_fixture(%{artist_name: "Special Artist", title: "Track 1"})
|
|
track_fixture(%{artist_name: "Regular Artist", title: "Track 2"})
|
|
|
|
count = ScrobbleActivity.search_tracks_count("Special")
|
|
|
|
assert count == 1
|
|
end
|
|
|
|
test "counts tracks matching album title" do
|
|
track_fixture(%{album_title: "Special Album", title: "Track 1"})
|
|
track_fixture(%{album_title: "Regular Album", title: "Track 2"})
|
|
|
|
count = ScrobbleActivity.search_tracks_count("Special")
|
|
|
|
assert count == 1
|
|
end
|
|
end
|
|
|
|
defp list_tracks do
|
|
ScrobbleActivity.list_tracks()
|
|
|> Enum.map(fn r -> r.track end)
|
|
end
|
|
|
|
describe "count_tracks_missing_artist_musicbrainz_id/0" do
|
|
test "returns zero when no tracks exist" do
|
|
count = ScrobbleActivity.count_tracks_missing_artist_musicbrainz_id()
|
|
|
|
assert count == 0
|
|
end
|
|
|
|
test "returns count of tracks with empty artist musicbrainz_id" do
|
|
track_fixture(%{artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_musicbrainz_id: "valid-id"})
|
|
|
|
count = ScrobbleActivity.count_tracks_missing_artist_musicbrainz_id()
|
|
|
|
assert count == 2
|
|
end
|
|
end
|
|
|
|
describe "count_tracks_missing_album_musicbrainz_id/0" do
|
|
test "returns zero when no tracks exist" do
|
|
count = ScrobbleActivity.count_tracks_missing_album_musicbrainz_id()
|
|
|
|
assert count == 0
|
|
end
|
|
|
|
test "returns count of tracks with empty album musicbrainz_id" do
|
|
track_fixture(%{album_musicbrainz_id: ""})
|
|
track_fixture(%{album_musicbrainz_id: ""})
|
|
track_fixture(%{album_musicbrainz_id: "valid-id"})
|
|
|
|
count = ScrobbleActivity.count_tracks_missing_album_musicbrainz_id()
|
|
|
|
assert count == 2
|
|
end
|
|
end
|
|
|
|
describe "get_artists_missing_musicbrainz_id/1" do
|
|
test "returns empty list when no tracks exist" do
|
|
result = ScrobbleActivity.get_artists_missing_musicbrainz_id()
|
|
|
|
assert result == []
|
|
end
|
|
|
|
test "returns artists grouped by name with track counts" do
|
|
track_fixture(%{artist_name: "Artist A", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist A", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist B", artist_musicbrainz_id: ""})
|
|
|
|
result = ScrobbleActivity.get_artists_missing_musicbrainz_id()
|
|
|
|
assert length(result) == 2
|
|
|
|
artist_a = Enum.find(result, fn r -> r.artist_name == "Artist A" end)
|
|
artist_b = Enum.find(result, fn r -> r.artist_name == "Artist B" end)
|
|
|
|
assert artist_a.track_count == 2
|
|
assert artist_b.track_count == 1
|
|
end
|
|
|
|
test "orders artists by track count descending" do
|
|
track_fixture(%{artist_name: "Artist A", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist B", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist B", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist B", artist_musicbrainz_id: ""})
|
|
|
|
result = ScrobbleActivity.get_artists_missing_musicbrainz_id()
|
|
|
|
assert length(result) == 2
|
|
assert List.first(result).artist_name == "Artist B"
|
|
assert List.first(result).track_count == 3
|
|
end
|
|
|
|
test "limits results when limit option provided" do
|
|
track_fixture(%{artist_name: "Artist A", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist B", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist C", artist_musicbrainz_id: ""})
|
|
|
|
result = ScrobbleActivity.get_artists_missing_musicbrainz_id(limit: 2)
|
|
|
|
assert length(result) == 2
|
|
end
|
|
|
|
test "excludes artists with valid musicbrainz_id" do
|
|
track_fixture(%{artist_name: "Artist A", artist_musicbrainz_id: ""})
|
|
track_fixture(%{artist_name: "Artist B", artist_musicbrainz_id: "valid-id"})
|
|
|
|
result = ScrobbleActivity.get_artists_missing_musicbrainz_id()
|
|
|
|
assert length(result) == 1
|
|
assert List.first(result).artist_name == "Artist A"
|
|
end
|
|
end
|
|
|
|
describe "get_albums_missing_musicbrainz_id/1" do
|
|
test "returns empty list when no tracks exist" do
|
|
result = ScrobbleActivity.get_albums_missing_musicbrainz_id()
|
|
|
|
assert result == []
|
|
end
|
|
|
|
test "returns albums grouped by title and artist with track counts" do
|
|
track_fixture(%{
|
|
album_title: "Album A",
|
|
artist_name: "Artist X",
|
|
album_musicbrainz_id: ""
|
|
})
|
|
|
|
track_fixture(%{
|
|
album_title: "Album A",
|
|
artist_name: "Artist X",
|
|
album_musicbrainz_id: ""
|
|
})
|
|
|
|
track_fixture(%{
|
|
album_title: "Album B",
|
|
artist_name: "Artist Y",
|
|
album_musicbrainz_id: ""
|
|
})
|
|
|
|
result = ScrobbleActivity.get_albums_missing_musicbrainz_id()
|
|
|
|
assert length(result) == 2
|
|
|
|
album_a = Enum.find(result, fn r -> r.album_title == "Album A" end)
|
|
album_b = Enum.find(result, fn r -> r.album_title == "Album B" end)
|
|
|
|
assert album_a.track_count == 2
|
|
assert album_a.artist_name == "Artist X"
|
|
assert album_b.track_count == 1
|
|
assert album_b.artist_name == "Artist Y"
|
|
end
|
|
|
|
test "orders albums by track count descending" do
|
|
track_fixture(%{album_title: "Album A", album_musicbrainz_id: ""})
|
|
track_fixture(%{album_title: "Album B", album_musicbrainz_id: ""})
|
|
track_fixture(%{album_title: "Album B", album_musicbrainz_id: ""})
|
|
track_fixture(%{album_title: "Album B", album_musicbrainz_id: ""})
|
|
|
|
result = ScrobbleActivity.get_albums_missing_musicbrainz_id()
|
|
|
|
assert length(result) == 2
|
|
assert List.first(result).album_title == "Album B"
|
|
assert List.first(result).track_count == 3
|
|
end
|
|
|
|
test "limits results when limit option provided" do
|
|
track_fixture(%{album_title: "Album A", album_musicbrainz_id: ""})
|
|
track_fixture(%{album_title: "Album B", album_musicbrainz_id: ""})
|
|
track_fixture(%{album_title: "Album C", album_musicbrainz_id: ""})
|
|
|
|
result = ScrobbleActivity.get_albums_missing_musicbrainz_id(limit: 2)
|
|
|
|
assert length(result) == 2
|
|
end
|
|
|
|
test "excludes albums with valid musicbrainz_id" do
|
|
track_fixture(%{album_title: "Album A", album_musicbrainz_id: ""})
|
|
track_fixture(%{album_title: "Album B", album_musicbrainz_id: "valid-id"})
|
|
|
|
result = ScrobbleActivity.get_albums_missing_musicbrainz_id()
|
|
|
|
assert length(result) == 1
|
|
assert List.first(result).album_title == "Album A"
|
|
end
|
|
end
|
|
|
|
defp list_tracks(params) do
|
|
ScrobbleActivity.list_tracks(params)
|
|
|> Enum.map(fn r -> r.track end)
|
|
end
|
|
end
|