5.0 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, documentation, modified_files, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | documentation | modified_files | priority | ordinal | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ML-185 | Simplify Presto artwork handling | Done | 2026-05-15 21:19 | 2026-05-16 20:23 |
|
|
|
medium | 19000 |
Description
Change the collection API artwork contract so the Presto client receives named cover assets instead of choosing among legacy flat cover URL fields or resizing them on the device.
Current state at task creation: MusicLibraryWeb.CollectionJSON emitted flat cover URL fields (cover_url, thumb_url, mini_cover_url, micro_cover_url). presto/main.py laid out list covers at 80 px (THUMB_SIZE = px(40) with UI_SCALE = 2) and detail covers at 480 px (DETAIL_COVER_SIZE = px(240)). The existing asset transform pipeline could already serve original images or resized images by width.
Target state: each API record representation exposes four named cover variants: original, large, medium, and small. The Presto app consumes covers.small for 80 px record-list thumbnails and covers.medium for record-detail artwork, while retaining the intended DETAIL_COVER_SIZE = px(200) 400 px detail-cover layout area. The client retains only JPEG decode/draw behavior, placeholder behavior, caching, and the existing rule that network fetches do not happen during drag redraws.
Acceptance Criteria
- #1 Collection API record JSON exposes four named cover variants: original, large, medium, and small.
- #2 The small cover is 80 px wide for the Presto record-list cover, the Presto detail view uses
covers.mediumwithin the intendedDETAIL_COVER_SIZE = px(200)400 px layout area, the large cover is 1000 px wide, and original is unscaled. - #3 The Presto application consumes the API-provided small and medium cover URLs directly and no longer contains client-side cover resizing or JPEG scale-selection logic.
- #4 Presto documentation and test fixtures describe the named cover contract and the intended 400 px detail-cover layout, and no longer refer to the legacy cover URL fields.
- #5 Relevant Phoenix and Presto tests are updated and pass.
Implementation Plan
- Update the Phoenix collection JSON contract so records expose named cover variants with widths derived from the API artwork contract and the requested 1000 px large variant.
- Update the Presto client to read the new cover names, use the 80 px row asset and
covers.mediumdetail asset directly, and remove JPEG scale-selection/resizing code while preservingDETAIL_COVER_SIZE = px(200), caching, placeholders, and drag-scroll network avoidance. - Update documentation, fixtures, and smoke/contract tests so the API and device assumptions stay aligned.
- Run the focused controller tests and Presto syntax/smoke tests; note that physical Presto behavior is not verified unless the device deployment task is run on hardware.
Implementation Notes
Both implementation subtasks are now Done. ML-185.1 updated the collection API to emit covers.original, covers.large, covers.medium, and covers.small. ML-185.2 updated the Presto app to consume covers.small and covers.medium, use an 80 px row cover and the intended DETAIL_COVER_SIZE = px(200) 400 px detail-cover layout, and remove JPEG resizing/scale-selection logic. Focused Phoenix controller tests and Presto syntax/smoke tests passed. Physical Presto hardware was not tested. This record was corrected after the detail cover layout was confirmed to be 400 px rather than 460 px.
Final Summary
Completed the artwork handling simplification across the collection API and Presto client.
The API now exposes named cover variants: original, large, medium, and small. The legacy flat cover fields were removed from the collection JSON contract.
The Presto app now consumes covers.small for record rows and covers.medium for detail pages, keeps the detail artwork in the intended DETAIL_COVER_SIZE = px(200) 400 px layout area, and no longer performs JPEG dimension probing or scale-selection resizing on-device. Documentation, guidance, mock fixtures, and smoke tests were updated for the named cover contract and corrected detail-cover layout.
Tests run across the subtasks: mix test test/music_library_web/controllers/collection_controller_test.exs; Presto syntax check; mise run test from presto/. Physical Presto hardware was not tested.