Claudio Ortolina
eb8a00ab54
Use Integer.parse/1 instead of String.to_integer/1 on user-supplied and external API input to prevent ArgumentError crashes on non-numeric values. Adds fallback defaults or nil returns at each call site.
85 lines
1.9 KiB
Elixir
85 lines
1.9 KiB
Elixir
defmodule LastFm.Artist do
|
|
use Ecto.Schema
|
|
|
|
import Ecto.Changeset
|
|
|
|
@type t :: %__MODULE__{
|
|
musicbrainz_id: String.t(),
|
|
name: String.t(),
|
|
summary: String.t(),
|
|
bio: String.t(),
|
|
image: String.t(),
|
|
play_count: non_neg_integer(),
|
|
on_tour: boolean(),
|
|
base_url: String.t(),
|
|
image_data_hash: String.t() | nil
|
|
}
|
|
|
|
@primary_key false
|
|
embedded_schema do
|
|
field :musicbrainz_id, :string
|
|
field :name, :string
|
|
field :summary, :string
|
|
field :bio, :string
|
|
field :image, :string
|
|
field :play_count, :integer, default: 0
|
|
field :on_tour, :boolean, default: false
|
|
field :base_url, :string
|
|
field :image_data_hash, :string
|
|
end
|
|
|
|
def from_api_response(api_response) do
|
|
%__MODULE__{
|
|
musicbrainz_id: api_response["mbid"],
|
|
name: api_response["name"],
|
|
summary: api_response["bio"]["summary"] || "",
|
|
bio: api_response["bio"]["content"] || "",
|
|
image: get_image(api_response),
|
|
play_count: get_play_count(api_response),
|
|
on_tour: api_response["ontour"] == "1",
|
|
base_url: api_response["url"]
|
|
}
|
|
end
|
|
|
|
def changeset(artist, attrs) do
|
|
artist
|
|
|> cast(attrs, [
|
|
:musicbrainz_id,
|
|
:name,
|
|
:summary,
|
|
:bio,
|
|
:image,
|
|
:play_count,
|
|
:on_tour,
|
|
:base_url
|
|
])
|
|
|> validate_required([:name])
|
|
end
|
|
|
|
def events_url(artist) do
|
|
artist.base_url <> "/+events"
|
|
end
|
|
|
|
defp get_image(api_response) do
|
|
api_response["image"]
|
|
|> Enum.find(%{"#text" => nil}, fn i -> i["size"] == "medium" end)
|
|
|> Map.get("#text")
|
|
end
|
|
|
|
defp get_play_count(api_response) do
|
|
case get_in(api_response, ["stats", "userplaycount"]) do
|
|
nil -> 0
|
|
value -> parse_play_count(value)
|
|
end
|
|
end
|
|
|
|
defp parse_play_count(value) when is_binary(value) do
|
|
case Integer.parse(value) do
|
|
{int, ""} -> int
|
|
_ -> 0
|
|
end
|
|
end
|
|
|
|
defp parse_play_count(_), do: 0
|
|
end
|