cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract biography helpers from ArtistLive.Show

Browse Source 
Closes #124
This commit is contained in:
Claudio Ortolina
2026-03-22 08:07:06 +00:00
parent b18a544156
commit 0edd5f317c
3 changed files with 176 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library_web/live/artist_live/biography.ex
+78
View File
@@ -0,0 +1,78 @@
defmodule MusicLibraryWeb.ArtistLive.Biography do
@moduledoc """
Helper functions for building and rendering artist biographies
from Wikipedia and Last.fm data.
"""
alias MusicLibrary.Artists.ArtistInfo
alias MusicLibraryWeb.Markdown
alias Phoenix.HTML
@spec build(ArtistInfo.t()) :: map() | nil
def build(artist_info) do
bio_html = ArtistInfo.wikipedia_bio(artist_info)
if bio_html do
%{
source: "Wikipedia",
summary_html: ArtistInfo.wikipedia_summary(artist_info),
bio_html: bio_html,
url: ArtistInfo.wikipedia_url(artist_info),
description: ArtistInfo.wikipedia_description(artist_info)
}
end
end
# Bios start with text, then a link to read more on Last.fm, followed by a license text.
# We split the bio at the read more link in order to render the license separately.
@spec render_bio(String.t()) :: Phoenix.HTML.safe()
def render_bio(bio) do
last_fm_link_regex = ~r/<a.*Read more on Last\.fm<\/a>\.*\s*/
case String.split(bio, last_fm_link_regex, include_captures: true) do
[text, link, ""] ->
reformatted_bio =
Enum.join(
[
text,
~s(<p class="mt-4 font-semibold text-zinc-700 hover:text-zinc-500 dark:text-zinc-300 dark:hover:text-zinc-200">#{link}</p>)
],
""
)
render_content(reformatted_bio)
[text, link, license] ->
reformatted_bio =
Enum.join(
[
text,
~s(<p class="mt-4 font-semibold text-zinc-700 hover:text-zinc-500 dark:text-zinc-300 dark:hover:text-zinc-200">#{link}</p>),
~s(<p class="mt-4 italic block">#{license}</p>)
],
""
)
render_content(reformatted_bio)
other ->
render_content(Enum.join(other, ""))
end
end
@spec remove_read_more_link(String.t()) :: Phoenix.HTML.safe()
def remove_read_more_link(summary) do
last_fm_link_regex = ~r/<a.*Read more on Last\.fm<\/a>\.*\s*/
reformatted_summary = String.replace(summary, last_fm_link_regex, "")
render_content(reformatted_summary)
end
# sobelow_skip ["XSS.Raw"]
# Markdown.to_html/1 sanitizes HTML via MDEx (ammonia)
defp render_content(content) do
content
|> Markdown.to_html()
|> HTML.raw()
end
end
lib/music_library_web/live/artist_live/show.ex
+6 -71
View File
@@ -6,8 +6,8 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
alias MusicLibrary.{Artists, Chats, Records}
alias MusicLibrary.Artists.ArtistInfo
alias MusicLibraryWeb.ArtistLive.Biography
alias MusicLibraryWeb.ErrorMessages
alias MusicLibraryWeb.Markdown
attr :country, :map, required: true
@@ -369,7 +369,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
class="text-zinc-700 dark:text-zinc-300"
>
<div class="dark:prose-invert prose prose-sm">
{remove_read_more_link(lastfm_artist_info.summary)}
{Biography.remove_read_more_link(lastfm_artist_info.summary)}
</div>
<.link
class="mt-2 block text-sm font-medium text-zinc-900 dark:text-zinc-400"
@@ -391,7 +391,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
placement="left"
>
<div class="dark:prose-invert prose prose-sm">
{render_bio(lastfm_artist_info.bio)}
{Biography.render_bio(lastfm_artist_info.bio)}
</div>
</.sheet>
</.async_result>
@@ -547,7 +547,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
{:noreply,
socket
|> assign(:artist_info, artist_info)
|> assign(:biography, build_biography(artist_info))
|> assign(:biography, Biography.build(artist_info))
|> put_toast(:info, gettext("Artist info refreshed successfully"))}
{:error, reason} ->
@@ -567,7 +567,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
{:noreply,
socket
|> assign(:artist_info, artist_info)
|> assign(:biography, build_biography(artist_info))
|> assign(:biography, Biography.build(artist_info))
|> put_toast(:info, gettext("Wikipedia data refreshed successfully"))}
{:error, reason} ->
@@ -676,7 +676,7 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
|> assign(:artist, artist)
|> assign(:artist_info, artist_info)
|> assign(:chat_count, Chats.count_chats(:artist, musicbrainz_id))
|> assign(:biography, build_biography(artist_info))
|> assign(:biography, Biography.build(artist_info))
|> assign(:external_links, ArtistInfo.external_links(artist_info))
|> assign(:country, ArtistInfo.country(artist_info))
|> assign_async(:lastfm_artist_info, fn ->
@@ -755,69 +755,4 @@ defmodule MusicLibraryWeb.ArtistLive.Show do
wishlist: Enum.sort_by(wishlist, fn r -> r.release_date end, :desc)
}
end
defp build_biography(artist_info) do
bio_html = ArtistInfo.wikipedia_bio(artist_info)
if bio_html do
%{
source: "Wikipedia",
summary_html: ArtistInfo.wikipedia_summary(artist_info),
bio_html: bio_html,
url: ArtistInfo.wikipedia_url(artist_info),
description: ArtistInfo.wikipedia_description(artist_info)
}
end
end
# Bios start with text, then a link to read more on Last.fm, followed by a license text.
# We split the bio at the read more link in order to render the license separately.
defp render_bio(bio) do
last_fm_link_regex = ~r/<a.*Read more on Last\.fm<\/a>\.*\s*/
case String.split(bio, last_fm_link_regex, include_captures: true) do
[text, link, ""] ->
reformatted_bio =
Enum.join(
[
text,
~s(<p class="mt-4 font-semibold text-zinc-700 hover:text-zinc-500 dark:text-zinc-300 dark:hover:text-zinc-200">#{link}</p>)
],
""
)
render_content(reformatted_bio)
[text, link, license] ->
reformatted_bio =
Enum.join(
[
text,
~s(<p class="mt-4 font-semibold text-zinc-700 hover:text-zinc-500 dark:text-zinc-300 dark:hover:text-zinc-200">#{link}</p>),
~s(<p class="mt-4 italic block">#{license}</p>)
],
""
)
render_content(reformatted_bio)
other ->
render_content(other)
end
end
defp remove_read_more_link(summary) do
last_fm_link_regex = ~r/<a.*Read more on Last\.fm<\/a>\.*\s*/
reformatted_summary = String.replace(summary, last_fm_link_regex, "")
render_content(reformatted_summary)
end
# sobelow_skip ["XSS.Raw"]
# Markdown.to_html/1 sanitizes HTML via MDEx (ammonia)
defp render_content(content) do
content
|> Markdown.to_html()
|> raw()
end
end
test/music_library_web/live/artist_live/biography_test.exs
+92
View File
@@ -0,0 +1,92 @@
defmodule MusicLibraryWeb.ArtistLive.BiographyTest do
use MusicLibrary.DataCase, async: true
alias MusicLibraryWeb.ArtistLive.Biography
import MusicLibrary.ArtistInfoFixtures
describe "build/1" do
test "returns biography map when Wikipedia data is present" do
artist_info =
artist_info_fixture(%{
wikipedia_data: %{
"intro_html" => "<p>A musician from England.</p>",
"extract" => "A musician from England.",
"content_urls" => %{"desktop" => %{"page" => "https://en.wikipedia.org/wiki/Test"}},
"description" => "English musician"
}
})
result = Biography.build(artist_info)
assert result.source == "Wikipedia"
assert result.bio_html == "<p>A musician from England.</p>"
assert result.summary_html == "A musician from England."
assert result.url == "https://en.wikipedia.org/wiki/Test"
assert result.description == "English musician"
end
test "returns nil when no Wikipedia data is present" do
artist_info = artist_info_fixture(%{wikipedia_data: nil})
assert Biography.build(artist_info) == nil
end
test "returns nil when Wikipedia data has no bio" do
artist_info = artist_info_fixture(%{wikipedia_data: %{}})
assert Biography.build(artist_info) == nil
end
end
describe "render_bio/1" do
test "renders bio with Last.fm link and no license" do
bio =
~s(Some artist biography text. <a href="https://www.last.fm/music/Test">Read more on Last.fm</a>)
result = Phoenix.HTML.safe_to_string(Biography.render_bio(bio))
assert result =~ "Some artist biography text."
assert result =~ "Read more on Last.fm"
end
test "renders bio with Last.fm link and license text" do
bio =
~s(Some artist biography text. <a href="https://www.last.fm/music/Test">Read more on Last.fm</a>. User-contributed text is available under the Creative Commons License.)
result = Phoenix.HTML.safe_to_string(Biography.render_bio(bio))
assert result =~ "Some artist biography text."
assert result =~ "Read more on Last.fm"
assert result =~ "Creative Commons License"
end
test "renders plain text bio without Last.fm link" do
bio = "Just a plain biography."
result = Biography.render_bio(bio)
assert Phoenix.HTML.safe_to_string(result) =~ "Just a plain biography."
end
end
describe "remove_read_more_link/1" do
test "strips Last.fm read more link from summary" do
summary =
~s(Some summary text. <a href="https://www.last.fm/music/Test">Read more on Last.fm</a>.)
result = Biography.remove_read_more_link(summary)
assert Phoenix.HTML.safe_to_string(result) =~ "Some summary text."
refute Phoenix.HTML.safe_to_string(result) =~ "Read more on Last.fm"
end
test "returns content as-is when no Last.fm link present" do
summary = "A summary without links."
result = Biography.remove_read_more_link(summary)
assert Phoenix.HTML.safe_to_string(result) =~ "A summary without links."
end
end
end