cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary selected_release_label/1

Browse Source
This commit is contained in:
Claudio Ortolina
2025-05-25 08:56:24 +01:00
parent b6c554af34
commit 1298d711a3
5 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library_web/components/record_components.ex
-8
View File
@@ -327,14 +327,6 @@ defmodule MusicLibraryWeb.RecordComponents do
def type_label(:single), do: gettext("Single") def type_label(:single), do: gettext("Single")
def type_label(:other), do: gettext("Other") def type_label(:other), do: gettext("Other")
def selected_release_label(record) do
if release = Records.Record.selected_release(record) do
release_label(release)
else
gettext("No release selected")
end
end
def release_label(release) do def release_label(release) do
[ [
release.date, release.date,
priv/gettext/default.pot
-1
View File
@@ -731,7 +731,6 @@ msgstr ""
msgid "Collected release" msgid "Collected release"
msgstr "" msgstr ""
#: lib/music_library_web/components/record_components.ex
#: lib/music_library_web/live/collection_live/show.html.heex #: lib/music_library_web/live/collection_live/show.html.heex
#: lib/music_library_web/live/wishlist_live/show.html.heex #: lib/music_library_web/live/wishlist_live/show.html.heex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
priv/gettext/en/LC_MESSAGES/default.po
-1
View File
@@ -731,7 +731,6 @@ msgstr ""
msgid "Collected release" msgid "Collected release"
msgstr "" msgstr ""
#: lib/music_library_web/components/record_components.ex
#: lib/music_library_web/live/collection_live/show.html.heex #: lib/music_library_web/live/collection_live/show.html.heex
#: lib/music_library_web/live/wishlist_live/show.html.heex #: lib/music_library_web/live/wishlist_live/show.html.heex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
test/music_library_web/live/collection_live/show_test.exs
+4 -3
View File
@@ -3,8 +3,7 @@ defmodule MusicLibraryWeb.CollectionLive.ShowTest do
import MusicLibrary.Fixtures.Records import MusicLibrary.Fixtures.Records
import MusicLibraryWeb.RecordComponents, import MusicLibraryWeb.RecordComponents, only: [format_label: 1, type_label: 1]
only: [format_label: 1, type_label: 1, selected_release_label: 1]
alias MusicBrainz.Fixtures alias MusicBrainz.Fixtures
alias MusicLibrary.Records.Record alias MusicLibrary.Records.Record
@@ -50,7 +49,9 @@ defmodule MusicLibraryWeb.CollectionLive.ShowTest do
|> assert_has("dd", text: Record.format_as_date(record.purchased_at)) |> assert_has("dd", text: Record.format_as_date(record.purchased_at))
|> assert_has("dd", text: record.id) |> assert_has("dd", text: record.id)
|> assert_has("a", text: record.musicbrainz_id) |> assert_has("a", text: record.musicbrainz_id)
|> assert_has("dd", text: selected_release_label(record)) |> assert_has("span", text: "Multi")
|> assert_has("span", text: "2004-05-03")
|> assert_has("span", text: "🇬🇧")
|> assert_has("dd", text: Record.format_as_date(record.inserted_at)) |> assert_has("dd", text: Record.format_as_date(record.inserted_at))
|> assert_has("dd", text: Record.format_as_date(record.updated_at)) |> assert_has("dd", text: Record.format_as_date(record.updated_at))
|> assert_has("img[src='#{cover_url}']") |> assert_has("img[src='#{cover_url}']")
test/music_library_web/live/wishlist_live/show_test.exs
+4 -3
View File
@@ -3,8 +3,7 @@ defmodule MusicLibraryWeb.WishlistLive.ShowTest do
import MusicLibrary.Fixtures.Records import MusicLibrary.Fixtures.Records
import MusicLibraryWeb.RecordComponents, import MusicLibraryWeb.RecordComponents, only: [format_label: 1, type_label: 1]
only: [format_label: 1, type_label: 1, selected_release_label: 1]
alias MusicLibrary.Records.Record alias MusicLibrary.Records.Record
@@ -34,7 +33,9 @@ defmodule MusicLibraryWeb.WishlistLive.ShowTest do
|> assert_has("p", text: type_label(record.type)) |> assert_has("p", text: type_label(record.type))
|> assert_has("dd", text: record.id) |> assert_has("dd", text: record.id)
|> assert_has("a", text: record.musicbrainz_id) |> assert_has("a", text: record.musicbrainz_id)
|> assert_has("dd", text: selected_release_label(record)) |> assert_has("span", text: "Multi")
|> assert_has("span", text: "2004-05-03")
|> assert_has("span", text: "🇬🇧")
|> assert_has("dd", text: Record.format_as_date(record.inserted_at)) |> assert_has("dd", text: Record.format_as_date(record.inserted_at))
|> assert_has("dd", text: Record.format_as_date(record.updated_at)) |> assert_has("dd", text: Record.format_as_date(record.updated_at))
|> assert_has("img[src='#{cover_url}']") |> assert_has("img[src='#{cover_url}']")