Refactor Favicon out

lib/music_library/artists.ex

@@ -3,6 +3,7 @@ defmodule MusicLibrary.Artists do
 
   alias MusicLibrary.Artists.ArtistInfo
   alias MusicLibrary.Assets
+  alias MusicLibrary.Favicon
   alias MusicLibrary.Records.{ArtistRecord, Record}
   alias MusicLibrary.Repo
   alias MusicLibrary.{BackgroundRepo, Worker}
@@ -162,10 +163,7 @@ defmodule MusicLibrary.Artists do
     |> Repo.update()
   end
 
-  def favicon_url(external_link) do
+  def favicon_url(external_link), do: Favicon.favicon_url(external_link.url)
-    uri = URI.parse(external_link.url)
-    "https://www.google.com/s2/favicons?domain=#{uri.host}&sz=16"
-  end
 
   defp get_collected_artist_ids do
     q =

lib/music_library/favicon.ex

@@ -0,0 +1,6 @@
+defmodule MusicLibrary.Favicon do
+  def favicon_url(url) do
+    uri = URI.parse(url)
+    "https://www.google.com/s2/favicons?domain=#{uri.host}&sz=16"
+  end
+end

lib/music_library/online_store_templates.ex

@@ -5,7 +5,7 @@ defmodule MusicLibrary.OnlineStoreTemplates do
 
   import Ecto.Query, warn: false
   alias MusicLibrary.OnlineStoreTemplates.OnlineStoreTemplate
-  alias MusicLibrary.Repo
+  alias MusicLibrary.{Favicon, Repo}
 
   @doc """
   Returns the list of enabled online store templates ordered by name.
@@ -76,8 +76,5 @@ defmodule MusicLibrary.OnlineStoreTemplates do
     |> String.replace("{format}", URI.encode_www_form(format_string))
   end
 
-  def favicon_url(template) do
+  def favicon_url(template), do: Favicon.favicon_url(template.url_template)
-    uri = URI.parse(template.url_template)
-    "https://www.google.com/s2/favicons?domain=#{uri.host}&sz=16"
-  end
 end