ML-146: honour API retry headers

This commit is contained in:
Claudio Ortolina
2026-04-25 07:29:28 +01:00
parent d588e5738f
commit 9113df5879
14 changed files with 363 additions and 38 deletions
+13 -6
View File
@@ -16,32 +16,36 @@ defmodule MusicBrainz.API.ErrorResponse do
@behaviour MusicLibrary.ErrorResponse
alias MusicLibrary.HttpError
alias MusicLibrary.RetryDelay
@type t :: %__MODULE__{
status: integer() | nil,
message: String.t() | nil,
kind: HttpError.kind(),
body: term()
body: term(),
retry_delay_seconds: pos_integer() | nil
}
defstruct [:status, :message, :kind, :body]
defstruct [:status, :message, :kind, :body, :retry_delay_seconds]
@spec from_response(Req.Response.t() | map()) :: t()
def from_response(%{status: 503, body: body} = _response) do
def from_response(%{status: 503, body: body} = response) do
%__MODULE__{
status: 503,
message: extract_message(body),
kind: :rate_limit,
body: body
body: body,
retry_delay_seconds: RetryDelay.retry_after_seconds(response)
}
end
def from_response(%{status: status, body: body} = _response) do
def from_response(%{status: status, body: body} = response) do
%__MODULE__{
status: status,
message: extract_message(body),
kind: HttpError.default_kind(status),
body: body
body: body,
retry_delay_seconds: RetryDelay.retry_after_seconds(response)
}
end
@@ -54,6 +58,9 @@ defmodule MusicBrainz.API.ErrorResponse do
@impl MusicLibrary.ErrorResponse
@spec retry_delay_seconds(t()) :: pos_integer()
def retry_delay_seconds(%__MODULE__{retry_delay_seconds: seconds}) when is_integer(seconds),
do: seconds
def retry_delay_seconds(%__MODULE__{kind: :rate_limit}), do: 60
def retry_delay_seconds(%__MODULE__{kind: :server_error}), do: 30
def retry_delay_seconds(%__MODULE__{kind: :timeout}), do: 10