Remove redundant tests

This commit is contained in:
Claudio Ortolina
2026-04-25 06:56:30 +01:00
parent ab4eaa8890
commit d588e5738f
7 changed files with 3 additions and 133 deletions
+3 -8
View File
@@ -7,13 +7,12 @@ defmodule MusicLibrary.Records.BatchTest do
describe "refresh_musicbrainz_data/0" do
test "enqueues refresh jobs for all records" do
_record = record()
record = record()
assert {:ok, []} = Batch.refresh_musicbrainz_data()
end
test "succeeds with no records" do
assert {:ok, []} = Batch.refresh_musicbrainz_data()
assert_enqueued worker: MusicLibrary.Worker.RecordRefreshMusicBrainzData,
args: %{id: record.id}
end
end
@@ -28,9 +27,5 @@ defmodule MusicLibrary.Records.BatchTest do
args: %{record_id: record.id}
)
end
test "succeeds with no records" do
assert {:ok, []} = Batch.generate_embeddings()
end
end
end
@@ -72,28 +72,6 @@ defmodule MusicLibrary.ScrobbleActivityTest do
assert {:error, :no_session_key} =
ScrobbleActivity.scrobble_release(@release, :started_at, DateTime.utc_now())
end
test "scrobble_medium/4 returns :no_session_key" do
assert {:error, :no_session_key} =
ScrobbleActivity.scrobble_medium(1, @release, :started_at, DateTime.utc_now())
end
test "scrobble_tracks/4 returns :no_session_key" do
track_ids =
@release
|> Release.tracks()
|> Enum.take(1)
|> Enum.map(& &1.id)
|> MapSet.new()
assert {:error, :no_session_key} =
ScrobbleActivity.scrobble_tracks(
track_ids,
@release,
:started_at,
DateTime.utc_now()
)
end
end
describe "scrobble_medium/4" do
@@ -124,13 +102,6 @@ defmodule MusicLibrary.ScrobbleActivityTest do
ScrobbleActivity.scrobble_medium(99, @release, :started_at, started_at)
end
test "returns error when medium not found with :finished_at" do
finished_at = DateTime.utc_now()
assert {:error, :medium_not_found} =
ScrobbleActivity.scrobble_medium(99, @release, :finished_at, finished_at)
end
test "returns error when medium has zero duration" do
zero_duration_medium = %Medium{
title: "",
@@ -1,20 +0,0 @@
defmodule MusicLibrary.Worker.ArtistRefreshAllDiscogsDataTest do
use MusicLibrary.DataCase
import MusicLibrary.Fixtures.Records
alias MusicLibrary.Worker.ArtistRefreshAllDiscogsData
describe "perform/1" do
test "enqueues refresh jobs for all artist infos" do
record = record()
artist = hd(record.artists)
artist_info = artist_info(artist.musicbrainz_id)
assert {:ok, []} = perform_job(ArtistRefreshAllDiscogsData, %{})
assert_enqueued worker: MusicLibrary.Worker.ArtistRefreshDiscogsData,
args: %{id: artist_info.id}
end
end
end
@@ -1,20 +0,0 @@
defmodule MusicLibrary.Worker.ArtistRefreshAllMusicBrainzDataTest do
use MusicLibrary.DataCase
import MusicLibrary.Fixtures.Records
alias MusicLibrary.Worker.ArtistRefreshAllMusicBrainzData
describe "perform/1" do
test "enqueues refresh jobs for all artist infos" do
record = record()
artist = hd(record.artists)
artist_info = artist_info(artist.musicbrainz_id)
assert {:ok, []} = perform_job(ArtistRefreshAllMusicBrainzData, %{})
assert_enqueued worker: MusicLibrary.Worker.ArtistRefreshMusicBrainzData,
args: %{id: artist_info.id}
end
end
end
@@ -1,20 +0,0 @@
defmodule MusicLibrary.Worker.ArtistRefreshAllWikipediaDataTest do
use MusicLibrary.DataCase
import MusicLibrary.Fixtures.Records
alias MusicLibrary.Worker.ArtistRefreshAllWikipediaData
describe "perform/1" do
test "enqueues refresh jobs for all artist infos" do
record = record()
artist = hd(record.artists)
artist_info = artist_info(artist.musicbrainz_id)
assert {:ok, []} = perform_job(ArtistRefreshAllWikipediaData, %{})
assert_enqueued worker: MusicLibrary.Worker.ArtistRefreshWikipediaData,
args: %{id: artist_info.id}
end
end
end
@@ -1,18 +0,0 @@
defmodule MusicLibrary.Worker.RecordGenerateAllEmbeddingsTest do
use MusicLibrary.DataCase
import MusicLibrary.Fixtures.Records
alias MusicLibrary.Worker.RecordGenerateAllEmbeddings
describe "perform/1" do
test "enqueues embedding generation jobs for all records" do
record = record()
assert {:ok, []} = perform_job(RecordGenerateAllEmbeddings, %{})
assert_enqueued worker: MusicLibrary.Worker.GenerateRecordEmbedding,
args: %{record_id: record.id}
end
end
end
@@ -1,18 +0,0 @@
defmodule MusicLibrary.Worker.RecordRefreshAllMusicBrainzDataTest do
use MusicLibrary.DataCase
import MusicLibrary.Fixtures.Records
alias MusicLibrary.Worker.RecordRefreshAllMusicBrainzData
describe "perform/1" do
test "enqueues refresh jobs for all records" do
record = record()
assert {:ok, []} = perform_job(RecordRefreshAllMusicBrainzData, %{})
assert_enqueued worker: MusicLibrary.Worker.RecordRefreshMusicBrainzData,
args: %{id: record.id}
end
end
end