cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ML-182.3: migrate record_set/show tests to PhoenixTest

Browse Source
This commit is contained in:
Claudio Ortolina
2026-05-15 06:47:25 +01:00
parent bd09840443
commit 9eda49ed46
2 changed files with 71 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backlog/tasks/ml-182.3 - Wave-3-Convert-live-2-→-visit-2-for-CRUD-LiveViews-6-files.md
+6 -2
View File
@@ -4,6 +4,7 @@ title: "Wave 3: Convert live/2 → visit/2 for CRUD LiveViews (6 files)"
status: In Progress
assignee: []
created_date: "2026-05-14 22:14"
updated_date: "2026-05-15 05:46"
labels:
- testing
- refactoring
@@ -28,8 +29,8 @@ Convert `live/2` → `visit/2` for standard CRUD LiveViews. Files:
- **maintenance_live/index_test.exs** ✅ Done (14 tests pass) — all `live/2` → `visit/2`, `render_click/3` → `click_button/2` with scoped selectors for duplicate button texts. External redirect test simplified. Kept `unwrap(&render_async/1)` for async status tests.
- **online_store_template_live/index_test.exs** ✅ Done (7 tests pass) — mixed `visit/2` and `live/2` eliminated. Field labels: "Template Name", "URL Template". Buttons: "Save Template", "Delete", "Disable/Enable template".
- **record_set_live/index_test.exs** ⏸️ Needs form label inspection — likely "Name" field, "Save" button.
- **record_set_live/show_test.exs** ⏸️ Complex: add-record modal with `phx-target`, `trigger_hook` for drag-and-drop, delete/remove buttons in dropdown menus. Need to inspect templates for exact button texts.
- **record_set_live/index_test.exs** ✅ Done (7 tests pass) — removed `import Phoenix.LiveViewTest`. Create/Edit: `live/2` + `form/3` + `render_submit/1` → `visit/2` + `fill_in/3` + `click_button/2`. Validation: `live/2` + `form/3` + `render_change/1` → `visit/2` + `click_button/2` + `assert_has("[data-part='error']", ...)`. Ordering test: `live/2` → `visit/2` + `Phoenix.LiveViewTest.render(session.view)`. Button text: "Save Set", field label: "Name".
- **record_set_live/show_test.exs** ✅ Done (15 tests pass) — removed `import Phoenix.LiveViewTest`, replaced with explicit `only:` for `render_click/1, render_hook/3, render_submit/1, element/2, form/3`. Remove record: `click_button("button[...]", "Remove")`. Delete set: `click_button("button[phx-click='delete_set']", "Delete")` + `assert_path`. Reorder: `unwrap(&render_hook/3)`. Picker search: `search_picker` helper uses `unwrap` with `form/3` + `render_submit/1`. Add record: `unwrap` with `element/2` + `render_click/1` on `<li phx-click='add_record'>`. Result checks use `assert_has`/`refute_has` instead of `=~` and `has_element?`.
- **scrobble_rules_live/index_test.exs** ⏸️ Needs form label inspection — "Match Value", "Target MusicBrainz ID", "Type" select, "Save" button.
- **scrobbled_tracks_live/rule_picker_test.exs** ⏸️ Blocked: clicks `<span>` badges with `phx-click` (Fluxon). PhoenixTest only supports `<a>` and `<button>`.
@@ -39,4 +40,7 @@ Key learnings for remaining files:
- Fluxon labels without separate visible text don't work with `fill_in` — visit with query params instead
- `trigger_hook` in PhoenixTest expects JSON-encoded values
- LiveComponent modals with `phx-target` need form interaction, not URL params
- For position-based assertions (ordering), use `Phoenix.LiveViewTest.render(session.view)` to get raw HTML
- `<li phx-click>` needs `unwrap` with `element/2` + `render_click/1` since PhoenixTest only supports `<a>` and `<button>` natively
- Forms inside LiveComponents (phx-target={@myself}) with no visible label on inputs need `unwrap` with `form/3` + `render_submit/1` for search/submit operations
<!-- SECTION:DESCRIPTION:END -->