Refactor Records.Record for simplification
- Remove unnecessary intermediate variables - Remove unnecessary pipes
This commit is contained in:
@@ -98,8 +98,7 @@ defmodule MusicLibrary.Records.Record do
|
|||||||
def update_release_ids(record = %__MODULE__{musicbrainz_data: musicbrainz_data}) do
|
def update_release_ids(record = %__MODULE__{musicbrainz_data: musicbrainz_data}) do
|
||||||
release_ids = Enum.map(musicbrainz_data["releases"], fn r -> r["id"] end)
|
release_ids = Enum.map(musicbrainz_data["releases"], fn r -> r["id"] end)
|
||||||
|
|
||||||
record
|
change(record, release_ids: release_ids)
|
||||||
|> change(release_ids: release_ids)
|
|
||||||
end
|
end
|
||||||
|
|
||||||
def update_release_ids(changeset) do
|
def update_release_ids(changeset) do
|
||||||
@@ -114,10 +113,9 @@ defmodule MusicLibrary.Records.Record do
|
|||||||
end
|
end
|
||||||
|
|
||||||
def update_included_release_group_ids(record = %__MODULE__{musicbrainz_data: musicbrainz_data}) do
|
def update_included_release_group_ids(record = %__MODULE__{musicbrainz_data: musicbrainz_data}) do
|
||||||
included_release_group_ids = extract_included_release_group_ids(musicbrainz_data)
|
change(record,
|
||||||
|
included_release_group_ids: extract_included_release_group_ids(musicbrainz_data)
|
||||||
record
|
)
|
||||||
|> change(included_release_group_ids: included_release_group_ids)
|
|
||||||
end
|
end
|
||||||
|
|
||||||
def update_included_release_group_ids(changeset) do
|
def update_included_release_group_ids(changeset) do
|
||||||
@@ -126,9 +124,11 @@ defmodule MusicLibrary.Records.Record do
|
|||||||
changeset
|
changeset
|
||||||
|
|
||||||
musicbrainz_data ->
|
musicbrainz_data ->
|
||||||
included_release_group_ids = extract_included_release_group_ids(musicbrainz_data)
|
put_change(
|
||||||
|
changeset,
|
||||||
put_change(changeset, :included_release_group_ids, included_release_group_ids)
|
:included_release_group_ids,
|
||||||
|
extract_included_release_group_ids(musicbrainz_data)
|
||||||
|
)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
@@ -144,9 +144,7 @@ defmodule MusicLibrary.Records.Record do
|
|||||||
end
|
end
|
||||||
|
|
||||||
def generate_cover_hash(record = %__MODULE__{cover_data: cover_data}) do
|
def generate_cover_hash(record = %__MODULE__{cover_data: cover_data}) do
|
||||||
record
|
change(record, cover_hash: Cover.hash(cover_data))
|
||||||
|> change()
|
|
||||||
|> put_change(:cover_hash, Cover.hash(cover_data))
|
|
||||||
end
|
end
|
||||||
|
|
||||||
def generate_cover_hash(changeset) do
|
def generate_cover_hash(changeset) do
|
||||||
|
|||||||
Reference in New Issue
Block a user