cloud/music_library
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change /covers to /assets

Browse Source
This commit is contained in:
Claudio Ortolina
2025-09-18 20:15:31 +03:00
parent e0ecafadd5
commit e158345674
10 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/music_library_web/components/record_components.ex
+1 -1
View File
@@ -21,7 +21,7 @@ defmodule MusicLibraryWeb.RecordComponents do
<img
class={@class}
alt={@record.title}
src={~p"/covers/#{@payload}"}
src={~p"/assets/#{@payload}"}
/>
"""
end
lib/music_library_web/controllers/artist_controller.ex
+2 -2
View File
@@ -3,7 +3,7 @@ defmodule MusicLibraryWeb.ArtistController do
alias MusicLibrary.Artists
alias MusicLibrary.Assets.Transform
alias MusicLibraryWeb.CoverController
alias MusicLibraryWeb.AssetController
def image(conn, %{"musicbrainz_id" => artist_id}) do
case Artists.get_image(artist_id) do
@@ -15,7 +15,7 @@ defmodule MusicLibraryWeb.ArtistController do
%Transform{hash: hash}
|> Transform.encode!()
CoverController.show(conn, %{"transform_payload" => payload})
AssetController.show(conn, %{"transform_payload" => payload})
end
end
lib/music_library_web/controllers/cover_controller.ex → lib/music_library_web/controllers/asset_controller.ex
+1 -1
View File
@@ -1,4 +1,4 @@
defmodule MusicLibraryWeb.CoverController do
defmodule MusicLibraryWeb.AssetController do
use MusicLibraryWeb, :controller
alias MusicLibrary.Assets
lib/music_library_web/controllers/collection_json.ex
+2 -2
View File
@@ -21,8 +21,8 @@ defmodule MusicLibraryWeb.CollectionJSON do
id: record.id,
artists: Enum.map(record.artists, & &1.name),
title: record.title,
cover_url: url(~p"/api/covers/#{%Transform{hash: record.cover_hash}}"),
thumb_url: url(~p"/api/covers/#{%Transform{hash: record.cover_hash, width: 480}}")
cover_url: url(~p"/api/assets/#{%Transform{hash: record.cover_hash}}"),
thumb_url: url(~p"/api/assets/#{%Transform{hash: record.cover_hash, width: 480}}")
}
end
end
lib/music_library_web/router.ex
+2 -2
View File
@@ -36,7 +36,7 @@ defmodule MusicLibraryWeb.Router do
get "/backup", ArchiveController, :backup
get "/covers/:transform_payload", CoverController, :show
get "/assets/:transform_payload", AssetController, :show
get "/artists/:musicbrainz_id/image", ArtistController, :image
live_session :default,
@@ -82,7 +82,7 @@ defmodule MusicLibraryWeb.Router do
get "/collection/latest", CollectionController, :latest
get "/collection/random", CollectionController, :random
get "/collection", CollectionController, :index
get "/covers/:transform_payload", CoverController, :show
get "/assets/:transform_payload", AssetController, :show
get "/backup", ArchiveController, :backup
end
test/music_library_web/controllers/cover_controller_test.exs → test/music_library_web/controllers/asset_controller_test.exs
+9 -9
View File
@@ -1,4 +1,4 @@
defmodule MusicLibraryWeb.CoverControllerTest do
defmodule MusicLibraryWeb.AssetControllerTest do
use MusicLibraryWeb.ConnCase
import MusicLibrary.Fixtures.Records
@@ -12,21 +12,21 @@ defmodule MusicLibraryWeb.CoverControllerTest do
%{asset: asset}
end
describe "GET /covers/:payload" do
describe "GET /assets/:payload" do
setup [:create_asset]
test "404s when asset doesn't exist", %{conn: conn} do
transform = %Transform{hash: Ecto.UUID.generate()}
payload = Transform.encode!(transform)
conn = get(conn, ~p"/covers/#{payload}")
conn = get(conn, ~p"/assets/#{payload}")
assert text_response(conn, 404) == "Not found"
end
test "serves the cover without etag", %{conn: conn, asset: asset} do
test "serves the asset without etag", %{conn: conn, asset: asset} do
transform = %Transform{hash: asset.hash}
payload = Transform.encode!(transform)
conn = get(conn, ~p"/covers/#{payload}")
conn = get(conn, ~p"/assets/#{payload}")
assert conn.status == 200
assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"]
@@ -36,14 +36,14 @@ defmodule MusicLibraryWeb.CoverControllerTest do
assert conn.resp_body == asset.content
end
test "serves the cover when etag doesn't match", %{conn: conn, asset: asset} do
test "serves the asset when etag doesn't match", %{conn: conn, asset: asset} do
transform = %Transform{hash: asset.hash}
payload = Transform.encode!(transform)
conn =
conn
|> put_req_header("if-none-match", "invalid-etag")
|> get(~p"/covers/#{payload}")
|> get(~p"/assets/#{payload}")
assert conn.status == 200
assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"]
@@ -60,7 +60,7 @@ defmodule MusicLibraryWeb.CoverControllerTest do
conn =
conn
|> put_req_header("if-none-match", payload)
|> get(~p"/covers/#{payload}")
|> get(~p"/assets/#{payload}")
assert conn.status == 304
assert get_resp_header(conn, "content-type") == []
@@ -74,7 +74,7 @@ defmodule MusicLibraryWeb.CoverControllerTest do
transform = %Transform{hash: asset.hash, width: 480}
payload = Transform.encode!(transform)
conn = get(conn, ~p"/covers/#{payload}")
conn = get(conn, ~p"/assets/#{payload}")
assert conn.status == 200
assert get_resp_header(conn, "content-type") == ["image/jpeg; charset=utf-8"]
test/music_library_web/controllers/collection_controller_test.exs
+6 -6
View File
@@ -32,9 +32,9 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
"artists" => ["Steven Wilson"],
"title" => record.title,
"cover_url" =>
"http://localhost:4002/api/covers/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
"http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
"thumb_url" =>
"http://localhost:4002/api/covers/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
"http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
}
end
end
@@ -60,9 +60,9 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
"artists" => ["Steven Wilson"],
"title" => record.title,
"cover_url" =>
"http://localhost:4002/api/covers/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
"http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
"thumb_url" =>
"http://localhost:4002/api/covers/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
"http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
}
end
end
@@ -92,9 +92,9 @@ defmodule MusicLibraryWeb.CollectionControllerTest do
"artists" => ["Steven Wilson"],
"title" => record.title,
"cover_url" =>
"http://localhost:4002/api/covers/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
"http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjpudWxsfQ",
"thumb_url" =>
"http://localhost:4002/api/covers/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
"http://localhost:4002/api/assets/eyJoYXNoIjoiNTk5NDA3RERGNjk5MDdENEE2MEZFMTNDQ0FBODI0RDI1Q0YwOERDMTI0RkQ2QUEzRThFN0VDRDk4Qzg4NUZGRSIsIndpZHRoIjo0ODB9"
}
]
}
test/music_library_web/live/collection_live/index_test.exs
+1 -1
View File
@@ -446,6 +446,6 @@ defmodule MusicLibraryWeb.CollectionLive.IndexTest do
defp cover_url(record, width) do
transform = %Transform{hash: record.cover_hash, width: width}
payload = Transform.encode!(transform)
~p"/covers/#{payload}"
~p"/assets/#{payload}"
end
end
test/music_library_web/live/collection_live/show_test.exs
+1 -1
View File
@@ -32,7 +32,7 @@ defmodule MusicLibraryWeb.CollectionLive.ShowTest do
record = record()
transform = %Transform{hash: record.cover_hash, width: nil}
payload = Transform.encode!(transform)
cover_url = ~p"/covers/#{payload}"
cover_url = ~p"/assets/#{payload}"
release_response = Fixtures.Release.release(:marbles)
test/music_library_web/live/wishlist_live/show_test.exs
+1 -1
View File
@@ -24,7 +24,7 @@ defmodule MusicLibraryWeb.WishlistLive.ShowTest do
record = record(purchased_at: nil)
transform = %Transform{hash: record.cover_hash, width: nil}
payload = Transform.encode!(transform)
cover_url = ~p"/covers/#{payload}"
cover_url = ~p"/assets/#{payload}"
session =
conn