Commit Graph

514 Commits

Author SHA1 Message Date
Claudio Ortolina 2321cc8cfb Attempt at preventing layout shifts in record show pages 2024-12-03 22:54:53 +00:00
Claudio Ortolina 2c055acad6 Fix error in rendering an artist with empty bio
Includes a refactor for a helper to test for play count
2024-12-03 22:26:41 +00:00
Claudio Ortolina bef38967a1 Stub artist show test 2024-12-03 20:16:35 +00:00
Claudio Ortolina 9f2335cfa0 Use correct LastFm api module 2024-12-03 20:14:48 +00:00
Claudio Ortolina 61cda5a62c Explicitly set auto-refresh config for LastFm refresh 2024-12-03 19:58:17 +00:00
Claudio Ortolina f58a5e83b7 Revert "Reduce pool size in test"
This reverts commit 7a26b6bda6.
2024-12-03 19:42:52 +00:00
Claudio Ortolina 907f480bc1 Improve formatting of bio read more link and license block
Prefer inline Tailwind classes for consistency with rest of the codebase
2024-12-03 19:37:37 +00:00
Claudio Ortolina acee09aab0 Format bio sections 2024-12-03 16:25:16 +00:00
Claudio Ortolina cf85c78852 Improve readability of artist bio 2024-12-03 10:37:37 +00:00
Claudio Ortolina 371ed511cc Render bio with <details> element 2024-12-03 10:01:22 +00:00
Claudio Ortolina 26e96994a4 Use full content for bio 2024-12-03 09:58:24 +00:00
Claudio Ortolina 4dc1228a2d Show "Biography not available" notice 2024-12-03 09:55:20 +00:00
Claudio Ortolina 6519a8b3e8 Space out bio a bit more 2024-12-03 09:51:43 +00:00
Claudio Ortolina 2c520be102 Tighten typography on artist h1 page 2024-12-03 09:51:03 +00:00
Claudio Ortolina b301a5da7d Display number of scrobbles per artist 2024-12-03 09:47:52 +00:00
Claudio Ortolina 669d2558d4 No need to expose LastFm.Config.new/1 2024-12-03 09:40:17 +00:00
Claudio Ortolina 916c381ed0 Add TODO 2024-12-03 09:40:17 +00:00
Claudio Ortolina ab7a8eeb5a Add play count to LastFm.Artist 2024-12-03 09:40:17 +00:00
Claudio Ortolina 2094c1cf7b Use LastFm.Config where needed 2024-12-03 09:18:55 +00:00
Claudio Ortolina b49434b789 Extract LastFm.Config module 2024-12-03 08:56:23 +00:00
Claudio Ortolina 9d02a8e00b Render bio with linebreaks 2024-12-03 00:33:37 +00:00
Claudio Ortolina d1190e31f9 Navigate to artist page instead of patching 2024-12-03 00:15:24 +00:00
Claudio Ortolina ccefc6e697 Update to new interpolation syntax
Includes a fix to a brittle test that failed due to changes in the
number of linebreaks.
2024-12-03 00:08:32 +00:00
Claudio Ortolina 9448e77e23 Update dependencies
phoenix 1.7.14 => 1.7.15
phoenix_live_view 1.0.0-rc.7 => 1.0.0-rc.8
2024-12-02 23:21:30 +00:00
Claudio Ortolina 2fde159e85 Add links to artist page 2024-12-02 21:43:58 +00:00
Claudio Ortolina b42b4744a0 Display records in artist page 2024-12-02 21:40:13 +00:00
Claudio Ortolina 797f30b9a4 Tag Last.fm errors as errors
Because they're always returned as 200 responses with custom error codes
(sigh).
2024-12-02 21:36:18 +00:00
Claudio Ortolina 18df3683fc Render a minimal artist page 2024-12-02 17:35:47 +00:00
Claudio Ortolina 0eaaab7d00 Not working 2024-12-02 12:40:09 +00:00
Claudio Ortolina 2d721774d6 Can fetch an artist info from Last.fm 2024-12-02 12:40:07 +00:00
Claudio Ortolina b63b3a633a Can fetch records by a specific artist 2024-12-02 10:55:12 +00:00
Claudio Ortolina 963b3c826f Extract Records.Artist 2024-12-02 10:55:12 +00:00
Claudio Ortolina eda0245c2c Format code 2024-12-02 09:38:20 +00:00
Claudio Ortolina 3733ef74ba Add batch function to remove artist IDs 2024-12-02 09:37:00 +00:00
Claudio Ortolina 228b4bc440 Use musicbrainz_id as a key for embedded artists 2024-12-02 09:23:13 +00:00
Claudio Ortolina 46b912709d Use Mix.Shell.IO helpers to print msgs to the terminal 2024-12-01 15:31:51 +00:00
Claudio Ortolina 53d2082ad0 Ensure flyctl is installed before running Mix tasks 2024-12-01 12:32:21 +00:00
Claudio Ortolina c4cafa0bf6 Extract fly helpers for Mix tasks 2024-12-01 12:27:07 +00:00
Claudio Ortolina bdfae15f35 When refreshing fixtures, store them pretty-printed 2024-12-01 12:18:37 +00:00
Claudio Ortolina c71f740eec Update and format JSON fixture files 2024-12-01 12:17:49 +00:00
Claudio Ortolina 7a26b6bda6 Reduce pool size in test
Due to SQLite having one single write transaction, database tests cannot
be executed async, making a large pool ineffective at best. A setting of
10 is enough for those tests where we perform multiple read operations
(which tend to be sequential anyway).

Test execution time before and after this change remains effectively the
same.
2024-11-30 22:41:56 +00:00
Claudio Ortolina c65a29c252 Use more restrictive LastFm request timeouts
Experimental: metrics show some long running requests
that end up hitting timeouts (at default values),
so we make them shorter to leverage retries
2024-11-30 20:21:51 +00:00
Claudio Ortolina cf51cab7ce Add basic test for Records.Cover module 2024-11-29 22:08:40 +00:00
Claudio Ortolina d9773bf45d Improve test description 2024-11-29 17:21:42 +00:00
Claudio Ortolina 84b5c4ba85 Update dependencies
thousand_island 1.3.6 => 1.3.7
2024-11-29 17:10:19 +00:00
Claudio Ortolina 3facdcb5bd Compile dev routes in test
As the route is rendered in the stats page, it needs to be enabled in
all Mix environments in order to avoid compile time warnings.
2024-11-29 15:26:59 +00:00
Claudio Ortolina 010c769b55 Stream 50 rows at a time for batch operations 2024-11-29 10:00:18 +00:00
Claudio Ortolina df9d18a21f Add nav link to dev dashboard
Invisible on mobile portrait layout - visible if device is turned to
landscape. Reasoning is that the dev dashboard is pretty unusable in
portrait mode anyway.
2024-11-29 08:33:29 +00:00
Claudio Ortolina 95e11d45d5 Tighten navigation menu on mobile 2024-11-29 08:29:21 +00:00
Claudio Ortolina 2b20f1c588 Update dependencies
ecto 3.12.4 => 3.12.5
2024-11-29 08:20:15 +00:00