Claudio Ortolina
16 lines
782 B
Markdown
16 lines
782 B
Markdown
---
|
|
description: Code review for a task implementation
|
|
argument-hint: "<TASK-ID>"
|
|
---
|
|
|
|
We're going to review the implementation of task $1.
|
|
|
|
Perform the review considering:
|
|
|
|
1. Best practices for development in Elixir, Erlang, OTP, Phoenix, and LiveView
|
|
2. Performance impact and profile
|
|
3. Security in depth
|
|
4. Test coverage and thoroughness. In particular make sure that tests actually exercise the behaviour under test, and that assertions are meaningful and exhaustive
|
|
5. Duplication, repetition, excessive or insufficient abstraction
|
|
6. If the implementation includes HTML, CSS, and client-side JavaScript evaluate accessibility, compliance with light/dark mode requirements, responsive design. Use the configured browser-based tooling to preview and evaluate pages as needed.
|